Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Spring Cloud Stream Retries #337

Closed
dzou opened this issue Feb 25, 2021 · 1 comment
Closed

Implement Spring Cloud Stream Retries #337

dzou opened this issue Feb 25, 2021 · 1 comment
Labels

Comments

@dzou
Copy link
Contributor

dzou commented Feb 25, 2021

Original issue here: spring-attic/spring-cloud-gcp#2406

Duplicating the issue here for visibility.

First, confirm whether or not the Spring Cloud Stream framework handles retries for non-pollable scenario (does not seem so, see original issue).

@dzou dzou added the pubsub label Feb 25, 2021
@meltsufin meltsufin added priority: p3 type: enhancement New feature or request labels Mar 29, 2021
@elefeint elefeint changed the title Followup Question about Spring Cloud Stream Retries Implement Spring Cloud Stream Retries May 20, 2021
@elefeint
Copy link
Contributor

elefeint commented Aug 5, 2022

For polling, retries are supported by Spring Cloud Stream framework. For streaming, retries on Pub/Sub service communication are handled by gRPC retry settings. If business logic should be retried, customers should wrap it with their own retry logic.

I still think Spring Cloud Stream documentation is somewhat incorrect, in that only polling retries are handled by the framework, while streaming retry logic is implemented directly in Kafka and Rabbit binders.

@elefeint elefeint closed this as completed Aug 5, 2022
prash-mi pushed a commit that referenced this issue Jun 20, 2023
Bumps [mockito-core](https://github.com/mockito/mockito) from 3.3.0 to 3.8.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v3.3.0...v3.8.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants