feat: Add sample using regex to rewrite a path#18
Merged
martijneken merged 7 commits intoGoogleCloudPlatform:mainfrom Aug 23, 2023
Merged
feat: Add sample using regex to rewrite a path#18martijneken merged 7 commits intoGoogleCloudPlatform:mainfrom
martijneken merged 7 commits intoGoogleCloudPlatform:mainfrom
Conversation
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
In C++ we use RE2 and Abseil. In Rust we use the regex crate. This example removes part of the path, but any URI mutation is feasible (path, query, fragment, etc). This depends on PR to add compile/link options in proxy-wasm-cpp-sdk. Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
arman-rye
reviewed
Jul 27, 2023
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
leonm1
approved these changes
Aug 23, 2023
Contributor
|
Glad to see the tests in CI worked well! |
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
leonm1
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In C++ we use RE2 and Abseil.
In Rust we use the regex crate.
This example removes part of the path, but any URI mutation is feasible (path, query, fragment, etc).
The C++ sample is excluded from the build until we resolve Emscripten blockers:
proxy-wasm/proxy-wasm-cpp-sdk#157
NOTE: leaving the code here because users can build the C++ plugin by using the PR above.