Skip to content

GCF: add multipart file-persistence note #3429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ace-n merged 5 commits into from
Apr 26, 2020
Merged

GCF: add multipart file-persistence note #3429

ace-n merged 5 commits into from
Apr 26, 2020

Conversation

@ace-n
Copy link

@ace-n ace-n commented Apr 18, 2020

Given that we added this note in the Java sample, I thought it was worth adding here.

Update main.py
735268d 
Given that we added this note in the Java sample, I thought it was worth adding here.
@ace-n ace-n requested a review from grant April 18, 2020 03:55
@ace-n ace-n requested a review from a team as a code owner April 18, 2020 03:55
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 18, 2020
@ace-n ace-n changed the title Update main.py GCF: add multipart file-persistence note Apr 18, 2020
@ace-n ace-n added the automerge Merge the pull request once unit tests and other checks pass. label Apr 18, 2020
@ace-n ace-n assigned grant and unassigned leahecole Apr 18, 2020
@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Apr 18, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Apr 18, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@ace-n ace-n added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Apr 19, 2020
@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Apr 19, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Apr 19, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Apr 19, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

tmatsuo
tmatsuo reviewed Apr 20, 2020
View reviewed changes
@busunkim96 busunkim96 removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 20, 2020
grant
grant approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note looks fine to me.
I didn't look as to why we're doing this in the first place.

@ace-n ace-n added the automerge Merge the pull request once unit tests and other checks pass. label Apr 24, 2020
@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Apr 24, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Apr 25, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@ace-n ace-n merged commit 1523c22 into master Apr 26, 2020
@ace-n ace-n deleted the multipart-note branch April 26, 2020 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

@grant grant grant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@grant grant

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ace-n @tmatsuo @grant @googlebot @leahecole @busunkim96