Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer/cicd_sample/utils/add_dags_to_composer.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def upload_dags_to_composer(
if len(dags) > 0:
# Note - the GCS client library does not currently support batch requests on uploads
# if you have a large number of files, consider using
# the Python subprocess module to run gsutil -m cp -r on your dags
# the Python subprocess module to run gcloud storage cp --recursive on your dags
# See https://cloud.google.com/storage/docs/gsutil/commands/cp for more info
Comment on lines +60 to 61
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the command was updated to gcloud storage, the documentation link still points to the old gsutil documentation. To avoid confusion, the URL should be updated to point to the gcloud storage cp documentation.

Suggested change
# the Python subprocess module to run gcloud storage cp --recursive on your dags
# See https://cloud.google.com/storage/docs/gsutil/commands/cp for more info
# the Python subprocess module to run gcloud storage cp --recursive on your dags
# See https://cloud.google.com/sdk/gcloud/reference/storage/cp for more info

storage_client = storage.Client()
bucket = storage_client.bucket(bucket_name)
Expand Down