Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push testgrid images using workload identity #219

Merged
merged 2 commits into from
Jan 10, 2020

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Jan 10, 2020

Also get rid of presets (only used in one location)

Need GoogleCloudPlatform/testgrid#82 to merge first
ref #202

These make jobs harder to understand. I will also shortly replace them with workload identity.
@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, Katharine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 4a64286 into GoogleCloudPlatform:master Jan 10, 2020
@google-oss-robot
Copy link
Collaborator

@fejta: Updated the following 2 configmaps:

  • config configmap in namespace default at cluster default using the following files:
    • key config.yaml using file prow/config.yaml
  • job-config configmap in namespace default at cluster default using the following files:
    • key esp-v2.yaml using file prow/prowjobs/GoogleCloudPlatform/esp-v2/esp-v2.yaml
    • key gcp-oss-test-infra-config.yaml using file prow/prowjobs/GoogleCloudPlatform/oss-test-infra/gcp-oss-test-infra-config.yaml

In response to this:

Also get rid of presets (only used in one location)

Need GoogleCloudPlatform/testgrid#82 to merge first
ref #202

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta fejta deleted the tg branch January 10, 2020 21:31
@fejta fejta mentioned this pull request Jan 10, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants