Skip to content

[confgenerator ] Set block_on_overflow and exporter batching in Otel Cloud Logging exporter.#2208

Merged
franciscovalentecastro merged 25 commits intomasterfrom
fcovalente-block-on-overflow
Mar 9, 2026
Merged

[confgenerator ] Set block_on_overflow and exporter batching in Otel Cloud Logging exporter.#2208
franciscovalentecastro merged 25 commits intomasterfrom
fcovalente-block-on-overflow

Conversation

@franciscovalentecastro
Copy link
Copy Markdown
Contributor

@franciscovalentecastro franciscovalentecastro commented Feb 13, 2026

Description

This PR sets the following configurations in the Otel Google Cloud Logging exporter :

  • block_on_overflow: true
  • Exporter batching instead of batchprocessor

Related issue

b/394636880

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

Comment thread confgenerator/confgenerator.go Outdated
// Set to mirror the 60s max limit of default retry window in Google Cloud Logging apiv2 go client :
// https://github.com/googleapis/google-cloud-go/blob/logging/v1.4.2/logging/apiv2/logging_client.go#L78-L90
"timeout": "60s",
config := map[string]interface{}{
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can you keep the original structure (Config inline in the return statement) so the diff is more readable?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

I was going to add the db_storage in the same change initially, so i needed a conditional for "If Non-Disk Buffered Receiver" -> "Then enabled sendind_queue persistence.". Not necessary in this PR.

Comment thread confgenerator/confgenerator.go Outdated
Comment thread confgenerator/confgenerator.go Outdated
@franciscovalentecastro franciscovalentecastro force-pushed the fcovalente-block-on-overflow branch from c804ccd to de1d584 Compare March 2, 2026 20:17
@franciscovalentecastro
Copy link
Copy Markdown
Contributor Author

All otel_logging tests were passing in ebcb1a0, though there were some unrelated go version failures. Merging.

@franciscovalentecastro franciscovalentecastro merged commit 1957871 into master Mar 9, 2026
22 of 31 checks passed
@franciscovalentecastro franciscovalentecastro deleted the fcovalente-block-on-overflow branch March 9, 2026 21:33
rafaelwestphal pushed a commit that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants