Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin upstream version of opentelemetry when running tests #270

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

DouglasHeriot
Copy link
Contributor

@DouglasHeriot DouglasHeriot commented Aug 3, 2023

The fix in #254 didn't apply to tox environments that run pip install .

In #256 test_detects_gce was failing with opentelemetry-sdk version 1.19.0 instead of 1.18.0

Also fix get_mock_server.sh not being in allowlist_externals

Fix in GoogleCloudPlatform#254 didn't apply to tox environments that run `pip install .`

`test_detects_gce` was failing with opentelemetry-sdk version 1.19.0
instead of 1.18.0
@aabmass
Copy link
Collaborator

aabmass commented Aug 3, 2023

/gcbrun

@aabmass
Copy link
Collaborator

aabmass commented Aug 3, 2023

/gcbrun

@aabmass aabmass enabled auto-merge (squash) August 3, 2023 18:59
@aabmass
Copy link
Collaborator

aabmass commented Aug 3, 2023

Thanks for the fix :)

@aabmass aabmass merged commit 9e1d393 into GoogleCloudPlatform:main Aug 3, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants