feat(monitoring-exporter): add disableCreateMetricDescriptors option to skip checking for metric descriptor existence #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge all new changes from the official Google repository.
This change creates an option to skip checking if metric descriptors exist before sending metrics. Skipping the metric descriptor check can prevent the clients from getting rate limited by Google when a large number are all started at the same time.
sethrwebster
commented
Sep 19, 2023
packages/opentelemetry-cloud-monitoring-exporter/test/monitoring.test.ts
Show resolved
Hide resolved
aabmass
reviewed
Sep 20, 2023
packages/opentelemetry-cloud-monitoring-exporter/src/monitoring.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-cloud-monitoring-exporter/src/external-types.ts
Outdated
Show resolved
Hide resolved
|
/gcbrun |
sethrwebster
changed the title
sethrwebster
changed the title
aabmass
approved these changes
Sep 21, 2023
packages/opentelemetry-cloud-monitoring-exporter/src/external-types.ts
Outdated
Show resolved
Hide resolved
|
/gcbrun |
|
/gcbrun |
|
CI is broken, I'll fix it |
|
I fixed the build, can you merge main in? Should be good to go then |
|
/gcbrun |
Codecov Report
@@ Coverage Diff @@
## main #623 +/- ##
=======================================
Coverage 97.68% 97.69%
=======================================
Files 18 18
Lines 691 693 +2
Branches 127 129 +2
=======================================
+ Hits 675 677 +2
Misses 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set, this flag causes the client to skip checking if metric descriptors exist and begin sending metrics immediately. This can be useful when starting a large number of clients simultaneously to keep them from getting rate limited by the Google API.
Fixes #621