chore: upgrade for opentelemtry js v0.12.0 #189
Conversation
aabmass
force-pushed
the
upgrade-0.12-188
branch
from
65069d5 to
8b42fd6
Compare
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
- Coverage 95.25% 95.18% -0.08%
==========================================
Files 11 11
Lines 337 332 -5
Branches 67 66 -1
==========================================
- Hits 321 316 -5
Misses 16 16
Continue to review full report at Codecov.
|
packages/opentelemetry-cloud-trace-propagator/test/CloudPropagator.test.ts
Show resolved
Hide resolved
| @@ -140,7 +140,7 @@ export class MetricExporter implements IMetricExporter { | |||
| cb(ExportResult.SUCCESS); | |||
| } | |||
|
|
|||
| shutdown(): void {} | |||
| async shutdown(): Promise<void> {} | |||
There was a problem hiding this comment.
just curious, where did this change come from?
There was a problem hiding this comment.
They changed the interface in the SDK: open-telemetry/opentelemetry-js#1439
| @@ -130,6 +130,7 @@ describe('transform', () => { | |||
| }); | |||
|
|
|||
| it('should drop unknown attribute types', () => { | |||
| // @ts-expect-error | |||
There was a problem hiding this comment.
The test is asserting that unsupported attribute types (like object here) are dropped, but it creates a TS error since it is not allowed. In this case, we expect the TS error but want to validate the behavior too
Part of #188
Upgrade OpenTelemetry peer dependencies to v0.12.0.
Distributionwas removed altogether