-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom MR mapping #854
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
==========================================
+ Coverage 61.03% 62.92% +1.88%
==========================================
Files 56 57 +1
Lines 5903 4955 -948
==========================================
- Hits 3603 3118 -485
+ Misses 2143 1677 -466
- Partials 157 160 +3 ☔ View full report in Codecov by Sentry. |
dashpole
reviewed
Jun 4, 2024
psx95
force-pushed
the
support-custom-mr
branch
3 times, most recently
from
June 4, 2024 15:04
55728dc
to
88878e9
Compare
dashpole
approved these changes
Jun 4, 2024
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Jun 19, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go) | `v1.23.0` -> `v1.24.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.23.0/v1.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.23.0/v1.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go) | `v0.47.0` -> `v0.48.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector/v0.47.0/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector/v0.47.0/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector/googlemanagedprometheus](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go) | `v0.47.0` -> `v0.48.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector%2fgooglemanagedprometheus/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector%2fgooglemanagedprometheus/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector%2fgooglemanagedprometheus/v0.47.0/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector%2fgooglemanagedprometheus/v0.47.0/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>GoogleCloudPlatform/opentelemetry-operations-go (github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector)</summary> ### [`v0.48.0`](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.48.0): v1.24.0 and v0.48.0 [Compare Source](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/compare/v0.47.0...v0.48.0) ##### What's Changed - Updating packages by [@​avilevy18](https://github.com/avilevy18) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/846](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/846) - Bump go to v1.22.3 in ci by [@​dashpole](https://github.com/dashpole) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/849](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/849) - Run e2e tests on GAE standard by [@​aabmass](https://github.com/aabmass) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/848](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/848) - Add host.id as a fallback for instance by [@​dashpole](https://github.com/dashpole) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/852](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/852) - feat(extension/googleclientauth): support id-token by [@​rinx](https://github.com/rinx) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/851](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/851) - Add support for exponential histograms in the GMP exporter by [@​dashpole](https://github.com/dashpole) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/853](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/853) - Add support for custom MR mapping by [@​psx95](https://github.com/psx95) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/854](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/854) - Update CI go version to 1.22.4 by [@​psx95](https://github.com/psx95) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/859](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/859) - prepare for v1.24.0/v0.48.0 ([#​858](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/issues/858)) by [@​psx95](https://github.com/psx95) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/860](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/860) ##### New Contributors - [@​rinx](https://github.com/rinx) made their first contribution in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/851](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/851) **Full Changelog**: GoogleCloudPlatform/opentelemetry-operations-go@v0.47.0...v0.48.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides a configuration option for the metrics exporter allowing users to specify mappings for custom MonitoredResource type.
The mapping logic for the custom MR type is activated based on the presence of
gcp.resource_type
resource attribute in the underlying OpenTelemetry resource.Sample usage with the proposed config changes
Testing
Configuration code for reference