Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal/ prefix for integrationtest #288

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Remove internal/ prefix for integrationtest #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions exporter/collector/integrationtests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ and compare requests against recorded expectation fixtures. Currently, these tes
metrics.

The fixtures are located in the [`testdata/fixtures`][fixtures] directory and registered in
[`internal/integrationtest/testcases.go`][testcases].
[`integrationtest/testcases.go`][testcases].

## Running Tests

Expand Down Expand Up @@ -81,17 +81,17 @@ To add a new test:

This is how the Ops Agent fixtures were generated.

1. Add an entry in [`internal/integrationtest/testcases.go`][testcases].
1. Add an entry in [`integrationtest/testcases.go`][testcases].
1. Run the script to record the expectation fixture. This will contain the expected requests
that the exporter makes to GCP services:

```sh
cd internal/integrationtest
cd integrationtest
go run cmd/recordfixtures/main.go
```

The generated file is a JSON encoded
[`MetricExpectFixture`](internal/integrationtest/fixtures.proto#L21) protobuf message.
[`MetricExpectFixture`](integrationtest/fixtures.proto#L21) protobuf message.

See [#229](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/229) for an
example PR.
Expand All @@ -107,4 +107,4 @@ If you need to see the build logs because tests are failing, just ask someone to
with you.

[fixtures]: testdata/fixtures
[testcases]: internal/integrationtest/testcases.go
[testcases]: integrationtest/testcases.go