Add exporter/metricbatcher to split metric batches into 200 points#1111
Closed
dashpole wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Closed
Add exporter/metricbatcher to split metric batches into 200 points#1111dashpole wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
dashpole wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
dashpole
force-pushed
the
temp_batcher_aio
branch
from
3ca66d5 to
9c73d55
Compare
Contributor
Author
|
I might actually have this implemented upstream soon, so this might not be neccessary... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
- Coverage 61.03% 0 -61.04%
==========================================
Files 56 0 -56
Lines 5903 0 -5903
==========================================
- Hits 3603 0 -3603
+ Misses 2143 0 -2143
+ Partials 157 0 -157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on open-telemetry/opentelemetry-go#7930.
I used AI to convert the upstream PoC into an exporter wrapper.
I tested this by writing a metric with 1000 cardinality against the OTLP metrics GCP service and verified that all timeseries are correctly ingested.
TODO: investigate errors I saw when running locally (seemed to do with target_info)