Skip to content
This repository was archived by the owner on Mar 17, 2022. It is now read-only.

Add environment mocking to local tests + a bugfix or two#19

Merged
ace-n merged 2 commits intomasterfrom
add-env-supertest
Aug 14, 2017
Merged

Add environment mocking to local tests + a bugfix or two#19
ace-n merged 2 commits intomasterfrom
add-env-supertest

Conversation

@ace-n
Copy link
Contributor

@ace-n ace-n commented Aug 9, 2017

(Required because this sample depends on environment variables for configuration.)

@ace-n ace-n requested a review from jmdobry August 9, 2017 17:03
@ace-n ace-n changed the title Add environment mocking to local tests [DO NOT MERGE] Add environment mocking to local tests Aug 9, 2017
@ace-n
Copy link
Contributor Author

ace-n commented Aug 9, 2017

Do not merge: further changes (and/or functionality) may be required to fully test nodejs-docs-samples.

@ace-n ace-n changed the title [DO NOT MERGE] Add environment mocking to local tests Add environment mocking to local tests Aug 10, 2017
@ace-n
Copy link
Contributor Author

ace-n commented Aug 10, 2017

This is good to merge now, once reviewed. 😄

@ace-n ace-n changed the title Add environment mocking to local tests Add environment mocking to local tests + a bugfix or two Aug 12, 2017
@ace-n ace-n merged commit 7757c00 into master Aug 14, 2017
@ace-n ace-n deleted the add-env-supertest branch August 14, 2017 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants