Update cloudbuild.yaml #924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ghost
reviewed
Nov 19, 2018
functions/ci_cd/cloudbuild.yaml
Outdated
| - name: 'gcr.io/cloud-builders/gcloud' | ||
| args: ['beta', 'functions', 'deploy', '[YOUR_FUNCTION_NAME]', '[YOUR_FUNCTION_TRIGGER]'] | ||
| dir: 'functions/autodeploy' | ||
| args: ['beta', 'functions', 'deploy', '[YOUR_DEPLOYED_FUNCTION_NAME]', '[YOUR_FUNCTION_TRIGGER]', '--runtime', '[YOUR_RUNTIME]', '--entry-point', '[YOUR_FUNCTION_NAME_IN_CODE]'] |
Contributor
|
Don't think so.
…On Mon, Nov 19, 2018 at 5:08 PM Eric Schmidt ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In functions/ci_cd/cloudbuild.yaml
<#924 (comment)>
:
> \ No newline at end of file
+ args: ['beta', 'functions', 'deploy', '[YOUR_DEPLOYED_FUNCTION_NAME]', '[YOUR_FUNCTION_TRIGGER]', '--runtime', '[YOUR_RUNTIME]', '--entry-point', '[YOUR_FUNCTION_NAME_IN_CODE]']
Is beta required?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#924 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfBFwAA2SLnHW8KO7HsBDaIuY_OLdMrcks5uwyvrgaJpZM4Ypr0g>
.
--
Stewart Reichling | Product Manager, Serverless | [email protected] |
650.906.3381
|
fhinkel
approved these changes
Nov 26, 2018
Contributor
fhinkel
left a comment
fhinkel
left a comment
There was a problem hiding this comment.
LGTM, if possible without extra beta. Thanks!
Contributor
|
ping @ace-n |
telpirion
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.5](https://www.github.com/googleapis/nodejs-vision/compare/v2.3.4...v2.3.5) (2021-06-29) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#923](https://www.github.com/googleapis/nodejs-vision/issues/923)) ([0292824](https://www.github.com/googleapis/nodejs-vision/commit/02928247cae0d8db0f4ced155e8f60c8d664cd17)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @stew-r