Add linter for healthcare/ #839
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
|
👋 I don't have a problem with this generally, but wouldn't it be a lot easier to just use prettier and eslint at the top level, instead of adding this to every sample? |
Contributor
Author
|
I know. Wanted to see what it looks like before I change linting on 66 samples. |
| @@ -0,0 +1,15 @@ | |||
| --- | |||
Contributor
There was a problem hiding this comment.
How do you feel about having these .eslintrc.yml and prettierrc files in the root of every sample? Should we consider just having a single config at the root of the repo, and then having overrides in the individual dirs if we need em?
Contributor
Author
There was a problem hiding this comment.
I have one file at the root and overrides where needed.
grayside
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release *beep* *boop* --- ## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#835) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f)) * **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298)) ### Build System * update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 12, 2022
🤖 I have created a release *beep* *boop* --- ## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#835) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f)) * **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298)) ### Build System * update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.