Skip to content

Fix docs — config.socketPath should be config.host #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ace-n merged 3 commits into from
Oct 10, 2018
Merged

Fix docs — config.socketPath should be config.host #749

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26f1e63
Fix docs — config.socketPath should be config.host
Rich-Harris Sep 27, 2018
9b138ab
Merge branch 'master' into patch-1
fhinkel Oct 8, 2018
e7c340f
Merge branch 'master' into patch-1
Oct 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion functions/sql/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ const pgConfig = {
};

if (process.env.NODE_ENV === 'production') {
pgConfig.socketPath = `/cloudsql/${connectionName}`;
pgConfig.host = `/cloudsql/${connectionName}`;
}

// Connection pools reuse connections between invocations,
Expand Down