Skip to content

Conversation

@shtief
Copy link

@shtief shtief commented Aug 29, 2018

gcloud app deploy
did not run without adding the handler

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 29, 2018
@ace-n ace-n requested a review from michaelawyu October 10, 2018 22:19
@ace-n
Copy link
Contributor

ace-n commented Oct 10, 2018

@michaelawyu can you investigate whether this change is necessary?

@shtief can you sign the CLA? We can't merge this until you do.

@michaelawyu
Copy link
Contributor

I remember that for all the new runtimes the handler section is no longer required; even in the cases where developers have to specify the hander section, the script field must be of the value auto.

@shtief If possible, would you mind checking the version of your Cloud SDK?

@fhinkel
Copy link
Contributor

fhinkel commented Nov 8, 2018

Closing this due to inactivity. Please reopen if needed. Thanks.

@fhinkel fhinkel closed this Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no This human has *not* signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants