Skip to content

Conversation

@SurferJeffAtGoogle
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2018
@codecov
Copy link

codecov bot commented Jun 22, 2018

Codecov Report

Merging #674 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac7d78a...d69509c. Read the comment docs.

# Set the folder in which the tests are run
env_vars: {
key: "PROJECT"
value: "error/reporting"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The folder is actually called error-reporting.

@fhinkel
Copy link
Contributor

fhinkel commented Jun 25, 2018

Thanks! Everything in appengine or functions needs to end up in the appengine or functions directory, respectively. For everything else we don't have subfolders because they would mostly only have one entry. But those would shift around later, as we figure out common environment variables and build scripts.

@SurferJeffAtGoogle
Copy link
Contributor Author

Ready for another look.

@fhinkel fhinkel merged commit e55a6d1 into GoogleCloudPlatform:master Jun 26, 2018
NimJay pushed a commit that referenced this pull request Nov 10, 2022
🤖 I have created a release *beep* *boop*
---


## [5.0.1](googleapis/nodejs-language@v5.0.0...v5.0.1) (2022-06-30)


### Bug Fixes

* **docs:** describe fallback rest option ([#673](googleapis/nodejs-language#673)) ([6767804](googleapis/nodejs-language@6767804))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
NimJay pushed a commit that referenced this pull request Nov 10, 2022
🤖 I have created a release *beep* *boop*
---


## [5.0.1](googleapis/nodejs-language@v5.0.0...v5.0.1) (2022-06-30)


### Bug Fixes

* **docs:** describe fallback rest option ([#673](googleapis/nodejs-language#673)) ([6767804](googleapis/nodejs-language@6767804))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants