Skip to content

Fix hello world tests on CircleCi #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhinkel merged 2 commits into from
Jun 5, 2018
Merged

Fix hello world tests on CircleCi #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9960415
Fix folder for helloworld CircleCi tests
fhinkel Jun 5, 2018
dac7efd
Merge branch 'master' into FixHelloWorld
fhinkel Jun 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions appengine/hello-world/flexible/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@
"e2e-test": "repo-tools test deploy"
},
"dependencies": {
"express": "4.16.2"
"express": "^4.16.3"
},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "2.2.1"
"@google-cloud/nodejs-repo-tools": "^2.3.0",
"semistandard": "^12.0.1"
},
"cloud-repo-tools": {
"test": {
Expand Down
11 changes: 6 additions & 5 deletions appengine/hello-world/standard/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,18 @@
"scripts": {
"deploy": "gcloud app deploy",
"start": "node app.js",
"lint": "samples lint",
"lint": "repo-tools lint",
"pretest": "npm run lint",
"system-test": "samples test app",
"system-test": "repo-tools test app",
"test": "npm run system-test",
"e2e-test": "samples test deploy"
"e2e-test": "repo-tools test deploy"
},
"dependencies": {
"express": "4.16.2"
"express": "^4.16.3"
},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "2.2.1"
"@google-cloud/nodejs-repo-tools": "^2.3.0",
"semistandard": "^12.0.1"
},
"cloud-repo-tools": {
"test": {
Expand Down
3 changes: 2 additions & 1 deletion circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ deployment:
- node scripts/build "appengine/datastore"
- node scripts/build "appengine/endpoints"
- node scripts/build "appengine/errorreporting"
- node scripts/build "appengine/hello-world"
- node scripts/build "appengine/flexible/hello-world"
- node scripts/build "appengine/standard/hello-world"
- node scripts/build "appengine/mailjet"
- node scripts/build "appengine/metadata/flexible"
- node scripts/build "appengine/metadata/standard"
Expand Down