Skip to content

Adds backoff / retry to HTTP calls. #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gguuss merged 4 commits into from
Jan 9, 2018
Merged

Adds backoff / retry to HTTP calls. #545

gguuss merged 4 commits into from
Jan 9, 2018

Conversation

@gguuss
Copy link
Contributor

@gguuss gguuss commented Jan 5, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jan 5, 2018 •
edited
Loading

Codecov Report

Merging #545 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #545   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           3      3           
=====================================
  Hits            3      3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cb34c0...be80033. Read the comment docs.

ace-n
ace-n suggested changes Jan 5, 2018
View reviewed changes
iot/http_example/package.json Outdated
"jsonwebtoken": "7.4.1",
"request": "2.82.0",
"uuid": "3.1.0"
"requestretry": "requestretry",
Copy link
Contributor

@ace-n ace-n Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a SemVer number? e.g. 1.12.2, the latest version of the library.

Copy link
Contributor Author

@gguuss gguuss Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched.

iot/http_example/cloudiot_http_example.js Outdated
console.log(`Getting config from URL: ${urlBase}`);

// Custom backoff functions
function retryNotSuccess (err, response, body) {
Copy link
Contributor

@ace-n ace-n Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a library that comes with these built-in? (Perhaps nodejs-repo-tools?)

Copy link
Contributor Author

@gguuss gguuss Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, switched to recommended library that uses built-in exponential backoff.

iot/http_example/cloudiot_http_example.js Outdated
};

// Custom backoff functions
function retryNotSuccess (err, response, body) {
Copy link
Contributor

@ace-n ace-n Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto to below comment - can these come from a library?

Copy link
Contributor Author

@gguuss gguuss Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, switched to recommended library that uses built-in exponential backoff.

ace-n
ace-n approved these changes Jan 5, 2018
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once nits are fixed. 👍

iot/http_example/cloudiot_http_example.js
// Send events for high-frequency updates, update state only occasionally.
const delayMs = argv.messageType === 'events' ? 1000 : 2000;
request.post(options, function (error, response, body) {
console.log(JSON.stringify(request));
Copy link
Contributor

@ace-n ace-n Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended?

iot/http_example/cloudiot_http_example.js
const fs = require('fs');
const jwt = require('jsonwebtoken');
const request = require('requestretry');
const request = require('retry-request');
Copy link
Contributor

@ace-n ace-n Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we name this something other than request (to avoid confusion with the library of the same name)? Maybe retryRequest?

ace-n
ace-n reviewed Jan 5, 2018
View reviewed changes
iot/http_example/cloudiot_http_example.js
return incomingHttpMessage.statusMessage !== 'OK';
}
};
console.log(JSON.stringify(request.RetryStrategies));
Copy link
Contributor

@ace-n ace-n Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto - is this intended?

ace-n
ace-n reviewed Jan 5, 2018
View reviewed changes
iot/http_example/cloudiot_http_example.js
};
console.log(JSON.stringify(request.RetryStrategies));
request.get(options, function (error, response, body) {
request(options, function (error, response, body) {
Copy link
Contributor

@ace-n ace-n Jan 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: arrow function?

(Apply this comment throughout your PR if you decide to make any changes.)

@gguuss gguuss merged commit fbb2f8a into master Jan 9, 2018
@gguuss gguuss deleted the exponential-backoff branch February 26, 2018 19:13
@snyk-bot snyk-bot mentioned this pull request Sep 5, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2022
Open
grayside pushed a commit that referenced this pull request Oct 26, 2022
@release-please
chore: release 2.3.4 (#545)
193784c 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.4](https://www.github.com/googleapis/nodejs-tasks/compare/v2.3.3...v2.3.4) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#543](https://www.github.com/googleapis/nodejs-tasks/issues/543)) ([d1a715d](https://www.github.com/googleapis/nodejs-tasks/commit/d1a715d92e0136b1840798c2e122e165201715cd))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@grayside grayside mentioned this pull request Oct 26, 2022
Merged
grayside pushed a commit that referenced this pull request Nov 3, 2022
@release-please @grayside
chore: release 2.3.4 (#545)
23e2e7c 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.4](https://www.github.com/googleapis/nodejs-tasks/compare/v2.3.3...v2.3.4) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#543](https://www.github.com/googleapis/nodejs-tasks/issues/543)) ([d1a715d](https://www.github.com/googleapis/nodejs-tasks/commit/d1a715d92e0136b1840798c2e122e165201715cd))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore: release 3.3.2 (#545)
8752269 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@ace-n ace-n mentioned this pull request Nov 16, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore: release 3.3.2 (#545)
d4db78a 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@renovate-bot
chore(deps): update dependency mocha to v8 (#545)
4615f83
@ace-n ace-n mentioned this pull request Nov 17, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@renovate-bot
chore(deps): update dependency mocha to v8 (#545)
2f354a6
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore: release 3.3.2 (#545)
8f9c120 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@renovate-bot
chore(deps): update dependency mocha to v8 (#545)
c492c14
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@renovate-bot
chore(deps): update dependency mocha to v8 (#545)
c2d68c5
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@renovate-bot
chore(deps): update dependency mocha to v8 (#545)
81fb6a0
@ninadhatkar ninadhatkar mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ace-n ace-n ace-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gguuss @ace-n