Skip to content

Adds token refresh to HTTP example. #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gguuss merged 2 commits into from
Nov 3, 2017
Merged

Adds token refresh to HTTP example. #517

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dbbbc1
Adds token refresh to HTTP example.
gguuss Nov 2, 2017
5a28248
Review feedback
gguuss Nov 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions iot/http_example/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ Options:
Either RS256 (RSA) or ES256 (Eliptic Curve)
--cloud_region [region] GCP cloud region
--num_messages [num] Number of messages to publish.
--token_exp_mins [num] Minutes to JWT token expiration.
--http_bridge_address [address] HTTP bridge address.
--message_type [events|state] The message type to publish.

Expand Down
18 changes: 17 additions & 1 deletion iot/http_example/cloudiot_http_example_nodejs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ var argv = require(`yargs`)
requiresArg: true,
type: 'number'
},
token_exp_mins: {
default: 20,
description: 'Minutes to JWT token expiration.',
requiresArg: true,
type: 'number'
},
http_bridge_address: {
default: 'cloudiot-device.googleapis.com',
description: 'HTTP bridge address.',
Expand Down Expand Up @@ -145,6 +151,15 @@ function publishAsync (messageCount, numMessages) {
// If we have published fewer than numMessage messages, publish payload
// messageCount + 1.
setTimeout(function () {
let secsFromIssue = parseInt(Date.now() / 1000) - iatTime;
if (secsFromIssue > argv.token_exp_mins * 60) {
iatTime = parseInt(Date.now() / 1000);
console.log(`\tRefreshing token after ${secsFromIssue} seconds.`);

authToken = createJwt(argv.project_id, argv.private_key_file,
Copy link
Contributor

@ace-n ace-n Nov 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this feels like it should be a one-liner.

You can get it under 80 characters using camel case (like the non-IoT samples) and shortening privateKeyFile to keyFile. (Worst case scenario, it's probably fine to go a little over 80 characters unless the linter says not to.)

Copy link
Contributor Author

@gguuss gguuss Nov 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

argv.algorithm);
}

publishAsync(messageCount + 1, numMessages);
}, delayMs);
}
Expand All @@ -161,7 +176,8 @@ const devicePath = `projects/${argv.project_id}/locations/${argv.cloud_region}/r
const pathSuffix = argv.message_type === 'events'
? ':publishEvent' : ':setState';
const url = `https://${argv.http_bridge_address}/v1beta1/${devicePath}${pathSuffix}`;
const authToken = createJwt(argv.project_id, argv.private_key_file, argv.algorithm);
let iatTime = parseInt(Date.now() / 1000);
let authToken = createJwt(argv.project_id, argv.private_key_file, argv.algorithm);

// Publish messages.
publishAsync(1, argv.num_messages);
Expand Down