-
Notifications
You must be signed in to change notification settings - Fork 2k
Update dependencies #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update dependencies #468
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
84a5c3e
Fix docs-samples tests, round 1
fd3f3f9
Fix circle.yml
a2aff7c
Add RUN_ALL_BUILDS flag
70589b5
More container builder bugfixes
0c254f4
Tweak env vars + remove manual proxy install
e7f2096
Env vars in bashrc don't evaluate dynamically, so avoid them
922ea87
Add semicolons for command ordering
079fec5
Add appengine/static-files test to circle.yaml
74bdcc2
Merge branch 'master' into jdobry-update-deps-2
bd8e9c4
Fix failing container builder tests
95566e6
Address comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| // Copyright 2017, Google, Inc. | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // NOTE: | ||
| // This app can only be fully tested when deployed, because | ||
| // Pub/Sub requires a live endpoint URL to hit. Nevertheless, | ||
| // these tests mock it and partially test it locally. | ||
|
|
||
| 'use strict'; | ||
|
|
||
| const test = require(`ava`); | ||
| const path = require(`path`); | ||
| const utils = require(`@google-cloud/nodejs-repo-tools`); | ||
|
|
||
| const message = `This is a test message sent at: `; | ||
| const payload = message + Date.now(); | ||
|
|
||
| const cwd = path.join(__dirname, `../`); | ||
| const requestObj = utils.getRequest({ cwd: cwd }); | ||
|
|
||
| test.serial.cb(`should send a message to Pub/Sub`, (t) => { | ||
| requestObj | ||
| .post(`/`) | ||
| .type('form') | ||
| .send({ payload: payload }) | ||
| .expect(200) | ||
| .expect((response) => { | ||
| t.is(response.text, `Message sent`); | ||
| }) | ||
| .end(t.end); | ||
| }); | ||
|
|
||
| test.serial.cb(`should receive incoming Pub/Sub messages`, (t) => { | ||
| requestObj | ||
| .post(`/pubsub/push`) | ||
| .query({ token: process.env.PUBSUB_VERIFICATION_TOKEN }) | ||
| .send({ | ||
| message: { | ||
| data: payload | ||
| } | ||
| }) | ||
| .expect(200) | ||
| .end(t.end); | ||
| }); | ||
|
|
||
| test.serial.cb(`should check for verification token on incoming Pub/Sub messages`, (t) => { | ||
| requestObj | ||
| .post(`/pubsub/push`) | ||
| .field(`payload`, payload) | ||
| .expect(400) | ||
| .end(t.end); | ||
| }); | ||
|
|
||
| test.serial.cb(`should list sent Pub/Sub messages`, (t) => { | ||
| requestObj | ||
| .get(`/`) | ||
| .expect(200) | ||
| .expect((response) => { | ||
| t.regex(response.text, /Messages received by this instance/); | ||
| }) | ||
| .end(t.end); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need
./cloud_sql_proxy? Or is it expected thatcloud_sql_proxywill be on the path somewhere?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latter. According to the
Dockerfile, it's stored in/usr/local/bin- which I'm assuming is on thePATHalready.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, shouldn't this script just conditionally start the proxy? What if it's already running?