Skip to content

Conversation

@gryczj
Copy link
Contributor

@gryczj gryczj commented Oct 3, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj requested review from a team as code owners October 3, 2024 14:33
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Oct 3, 2024
@gryczj gryczj changed the title Feat compute reservation create shared feat: compute reservation create shared Oct 3, 2024
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 3, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 3, 2024
@gryczj gryczj force-pushed the feat_compute_reservation_create_shared branch from f069cfe to 716a391 Compare October 3, 2024 14:36
@snippet-bot
Copy link

snippet-bot bot commented Oct 3, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2024
@gryczj gryczj mentioned this pull request Oct 3, 2024
10 tasks
@gryczj
Copy link
Contributor Author

gryczj commented Oct 3, 2024

PR created as a replacement for #3832 last comments and conversation about the solution and implementation are available there.

@gryczj gryczj force-pushed the feat_compute_reservation_create_shared branch from 716a391 to 4cb3421 Compare October 3, 2024 17:21
@gryczj gryczj changed the title feat: compute reservation create shared feat: compute_reservation_create_shared, compute_reservation_create_from_vm Oct 3, 2024
@gryczj gryczj force-pushed the feat_compute_reservation_create_shared branch 2 times, most recently from d33adec to df54a2a Compare October 3, 2024 19:16
@gryczj gryczj force-pushed the feat_compute_reservation_create_shared branch 2 times, most recently from 3fea0b6 to cbc7ef9 Compare October 7, 2024 21:23
@gryczj gryczj requested a review from subfuzion October 7, 2024 21:32
@gryczj gryczj force-pushed the feat_compute_reservation_create_shared branch 7 times, most recently from 190bfec to c718a59 Compare October 8, 2024 11:00
@gryczj
Copy link
Contributor Author

gryczj commented Oct 8, 2024

Operation limits for storagePools and disk exceed.

@gryczj gryczj force-pushed the feat_compute_reservation_create_shared branch 5 times, most recently from f35f438 to 2bb3b4f Compare October 9, 2024 08:36
@gryczj gryczj force-pushed the feat_compute_reservation_create_shared branch from 2bb3b4f to b1b0712 Compare October 9, 2024 09:58
@gryczj gryczj merged commit 9383872 into main Oct 9, 2024
@gryczj gryczj deleted the feat_compute_reservation_create_shared branch October 9, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants