Skip to content

Conversation

@gryczj
Copy link
Contributor

@gryczj gryczj commented Sep 6, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj requested review from a team as code owners September 6, 2024 12:20
@gryczj gryczj self-assigned this Sep 6, 2024
@snippet-bot
Copy link

snippet-bot bot commented Sep 6, 2024

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Sep 6, 2024
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 6, 2024
@gryczj gryczj force-pushed the compute_regional_template_create branch from d679dc7 to c17e6e8 Compare September 6, 2024 12:21
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 6, 2024
@gryczj gryczj force-pushed the compute_regional_template_create branch 2 times, most recently from f42a8e5 to e8fd84b Compare September 12, 2024 11:10
@gryczj gryczj force-pushed the compute_regional_template_create branch from e8fd84b to 056862a Compare September 16, 2024 11:27
@gryczj
Copy link
Contributor Author

gryczj commented Sep 16, 2024

Please, check and merge after: #3868. Issues with tests need to be resolved first.

@gryczj gryczj removed their assignment Sep 24, 2024
@gryczj gryczj force-pushed the compute_regional_template_create branch from 056862a to 7a6f686 Compare September 26, 2024 14:47
@gryczj gryczj force-pushed the compute_regional_template_create branch from 7a6f686 to 3210348 Compare October 3, 2024 18:36
@gryczj
Copy link
Contributor Author

gryczj commented Oct 3, 2024

Pipeline should be fixed after merging #3868

@gryczj gryczj force-pushed the compute_regional_template_create branch 2 times, most recently from 16dd26c to b579f5d Compare October 7, 2024 14:26
@gryczj gryczj force-pushed the compute_regional_template_create branch from 177149d to 5d2024e Compare October 9, 2024 10:54
@gryczj gryczj merged commit 9ac641e into main Oct 9, 2024
@gryczj gryczj deleted the compute_regional_template_create branch October 9, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants