Add Cloud Functions ImageMagick sample. #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdobry
force-pushed
the
functions-image
branch
from
b7a33d3 to
8f3541b
Compare
jmdobry
force-pushed
the
functions-image
branch
from
8f3541b to
b0b0cb8
Compare
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
=======================================
Coverage 83.88% 83.88%
=======================================
Files 4 4
Lines 422 422
=======================================
Hits 354 354
Misses 68 68Continue to review full report at Codecov.
|
ace-n
approved these changes
Apr 25, 2017
Contributor
ace-n
left a comment
ace-n
left a comment
There was a problem hiding this comment.
LGTM - comments are the questions/possible improvements I had in mind.
| * Replace `YOUR_BUCKET_NAME` with the name of your image Cloud Storage Bucket. | ||
| * Replace `YOUR_STAGE_BUCKET_NAME` with the name of your Cloud Storage Bucket. | ||
|
|
||
| 1. Upload an offensive image to your image Storage bucket, such as this image of |
| @@ -0,0 +1,105 @@ | |||
| /** | |||
Contributor
There was a problem hiding this comment.
Thought: do we want to add any system tests?
Member
Author
There was a problem hiding this comment.
The functions samples are all unit tests for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.