Skip to content

refactor: linting errors, updates to node 16 #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pattishin merged 4 commits into from
Aug 21, 2023
Merged

refactor: linting errors, updates to node 16 #3464

pattishin merged 4 commits into from
Aug 21, 2023

Conversation

@pattishin
Copy link
Contributor

@pattishin pattishin commented Aug 18, 2023 •
edited
Loading

Description

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: aiplatform Issues related to the AI Platform API. labels Aug 18, 2023
@pattishin pattishin changed the title refactor: updates samples to node 16 and resolves linting errors 🚧 refactor: linting errors, updates to node 16 🚧 Aug 18, 2023
@pattishin pattishin mentioned this pull request Aug 18, 2023
Closed
@pattishin pattishin force-pushed the fix/linting-errors branch 2 times, most recently from 3d45e23 to 5a320a1 Compare August 18, 2023 22:52
@pattishin
fix: adding in a skip for the gaming samples as it is referencing a p…
a8d7839 
…roject that seems to either not exist or has strict permissions, preventing the tests from running

refactor: move dataproc and media-livestream back to node 12
@pattishin pattishin marked this pull request as ready for review August 19, 2023 00:50
@pattishin pattishin requested review from a team as code owners August 19, 2023 00:50
@pattishin pattishin requested a review from a team August 19, 2023 00:50
@pattishin pattishin requested review from a team as code owners August 19, 2023 00:50
@pattishin pattishin requested a review from a team as a code owner August 19, 2023 00:50
@pattishin pattishin changed the title refactor: linting errors, updates to node 16 🚧 refactor: linting errors, updates to node 16 Aug 19, 2023
@pattishin pattishin mentioned this pull request Aug 19, 2023
Closed
@pattishin pattishin requested a review from kweinmeister August 19, 2023 00:58
@pattishin pattishin merged commit b942b62 into main Aug 21, 2023
@pattishin pattishin deleted the fix/linting-errors branch August 21, 2023 17:00
paulinawins pushed a commit that referenced this pull request Sep 11, 2023
@pattishin
refactor: linting errors, updates to node 16 (#3464)
ba91fb2 
* refactor: updates samples to node 16 and resolves linting errors

* fix: adding in a skip for the gaming samples as it is referencing a project that seems to either not exist or has strict permissions, preventing the tests from running

refactor: move dataproc and media-livestream back to node 12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kweinmeister kweinmeister kweinmeister approved these changes

@holtskinner holtskinner holtskinner approved these changes

Assignees

No one assigned

Labels

api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pattishin @kweinmeister @holtskinner