Skip to content

Fix datastore/functions test timing out #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ace-n merged 1 commit into from
Jan 19, 2023
Merged

Fix datastore/functions test timing out #2993

ace-n merged 1 commit into from
Jan 19, 2023

Conversation

@ace-n
Copy link
Contributor

@ace-n ace-n commented Jan 18, 2023 •
edited
Loading

Fixes #2755 + reverts #2761

This swaps a homebrew waitForReady function (that was continuously stalling) with the wait-port NPM module.

@ace-n ace-n added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 18, 2023
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: cloudfunctions Issues related to the Cloud Run functions API. labels Jan 18, 2023
@ace-n ace-n removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 18, 2023
@ace-n ace-n marked this pull request as ready for review January 18, 2023 21:56
@ace-n ace-n requested review from a team as code owners January 18, 2023 21:56
@ace-n ace-n changed the title Draft PR DO NOT MERGE Fix datastore/functions test timing out Jan 18, 2023
@pattishin pattishin self-assigned this Jan 19, 2023
@ace-n ace-n merged commit 783c085 into main Jan 19, 2023
@ace-n ace-n deleted the fix-2755 branch January 19, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pattishin pattishin pattishin approved these changes

@kweinmeister kweinmeister kweinmeister approved these changes

+2 more reviewers

@unforced unforced unforced approved these changes

@telpirion telpirion telpirion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pattishin pattishin

Labels

api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

datastore-functions test is taking 6h and failing

5 participants

@ace-n @pattishin @unforced @telpirion @kweinmeister