Skip to content

fix(run/logging): throw error if stdout is empty #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kweinmeister merged 4 commits into from
Dec 20, 2022
Merged

fix(run/logging): throw error if stdout is empty #2942

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40773bc
fix(run/logging): throw error if stdout is empty
Dec 16, 2022
25b3760
Lint fixes (whitespace)
Dec 16, 2022
1e07932
Merge branch 'main' into fix-run-logging
kweinmeister Dec 20, 2022
1ca7bd5
Merge branch 'main' into fix-run-logging
kweinmeister Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions run/logging-manual/test/system.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ async function runShellCmd(cmd, opts = {}) {
try {
console.log('Running command:', cmd);
const result = await exec(cmd, opts);

// Ensure that `stdout` isn't empty
if (!result.stdout) {
throw new Error(result.stderr);
}

return result;
} catch (err) {
console.log('Shell command failed!');
Expand Down