Skip to content

Conversation

@grayside
Copy link
Collaborator

Samples for Profiler should not have been merged here. Removing them is the only action needed.

@grayside grayside requested a review from a team as a code owner November 15, 2022 16:03
@snippet-bot
Copy link

snippet-bot bot commented Nov 15, 2022

Here is the summary of changes.

You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: cloudprofiler Issues related to the Cloud Profiler API. samples Issues that are directly related to samples. labels Nov 15, 2022
Copy link
Contributor

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

I approve these changes.
I checked Code Search and all instances of profiler_setup_nodejs_compute_engine and profiler_setup_nodejs_compute_engine are pulled from https://github.com/googleapis/cloud-profiler-nodejs.

Failing CI

The following CI test is failing:

Run JustinBeckwith/linkinator-action@v1
...
Error: Detected 1 broken links.
 appengine/README.md
   [0] http://localhost:8080/

I believe the failing test will be resolved by #2847.

Question

But I am curious, why are we not migrating these samples?

@NimJay
Copy link
Contributor

NimJay commented Nov 15, 2022

#2847 was just merged!
So we should expect JustinBeckwith/linkinator-action@v1 to pass now.
I updated this branch by merging main to retrigger the CI.

@grayside grayside enabled auto-merge (rebase) November 16, 2022 23:08
@grayside grayside merged commit 93e5ef3 into main Nov 17, 2022
@grayside grayside deleted the remove-profiler branch November 17, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudprofiler Issues related to the Cloud Profiler API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants