Skip to content

Update busboy sample to use on('close') #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unforced merged 8 commits into from
Nov 28, 2022
Merged

Update busboy sample to use on('close') #2766

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
56ea954
Update busboy sample to use on('close')
Sep 22, 2022
8904c57
Update busboy version
Sep 22, 2022
d979ba7
Merge branch 'main' into busboy-patch
iennae Sep 28, 2022
8d374e6
Merge branch 'main' into busboy-patch
grayside Nov 8, 2022
9f36e4f
Merge branch 'main' into busboy-patch
kweinmeister Nov 14, 2022
d1adfd1
Merge branch 'main' into busboy-patch
Nov 18, 2022
aaf7d0d
Merge branch 'main' of github.com:GoogleCloudPlatform/nodejs-docs-sam…
Nov 28, 2022
29bbb96
Merge branch 'main' into busboy-patch
Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion functions/http/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ exports.uploadFile = (req, res) => {
file.on('end', () => {
writeStream.end();
});
writeStream.on('finish', resolve);
writeStream.on('close', resolve);
writeStream.on('error', reject);
});
fileWrites.push(promise);
Expand Down
2 changes: 1 addition & 1 deletion functions/http/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"dependencies": {
"@google-cloud/storage": "^6.0.0",
"busboy": "^1.0.0",
"busboy": "^1.6.0",
"escape-html": "^1.0.3"
}
}