Skip to content

Conversation

@kdeus
Copy link
Contributor

@kdeus kdeus commented Nov 2, 2016

This will be its new home, once the docs are updated to point to this. This example is used in several different environments, so it doesn't make sense to have it in a GAE-specific directory.

@jeffmendoza
Copy link
Contributor

@jmdobry PTAL

@jeffmendoza
Copy link
Contributor

@kdeus can you add region tags like this: GoogleCloudPlatform/python-docs-samples@07dc919

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.


RUN npm install
ENV PORT=8081
ENTRYPOINT ["npm", "start"] No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing endline.

name: nginx-ssl
readOnly: true
- name: echo
image: b.gcr.io/endpoints/echo:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built and pushed to gcr.io/google-samples/node-echo:1.0

volumes:
- name: nginx-ssl
secret:
secretName: nginx-ssl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no secret named nginx-ssl

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffmendoza
Copy link
Contributor

@jmdobry @ace-n This is ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants