-
Notifications
You must be signed in to change notification settings - Fork 2k
Copied Endpoints Echo sample from /appengine/endpoints #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jmdobry PTAL |
|
@kdeus can you add region tags like this: GoogleCloudPlatform/python-docs-samples@07dc919 |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
|
||
| RUN npm install | ||
| ENV PORT=8081 | ||
| ENTRYPOINT ["npm", "start"] No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing endline.
| name: nginx-ssl | ||
| readOnly: true | ||
| - name: echo | ||
| image: b.gcr.io/endpoints/echo:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
built and pushed to gcr.io/google-samples/node-echo:1.0
| volumes: | ||
| - name: nginx-ssl | ||
| secret: | ||
| secretName: nginx-ssl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no secret named nginx-ssl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need to base it off of: https://github.com/GoogleCloudPlatform/endpoints-samples/blob/master/k8s/esp_echo_http_gke.yaml
This will be its new home, once the docs are updated to point to this. This example is used in several different environments, so it doesn't make sense to have it in a GAE-specific directory.