chore(functions/v2): address comments on CAL samples #2433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
api: cloudfunctions
Contributor
|
Thanks Ace for the PR. I hate to say, but I think we should revert L77-99 back to https://github.com/GoogleCloudPlatform/nodejs-docs-samples/pull/2402/files#diff-6a15ae6459f327c31196fce22c039e2db448984406823bd0f917727353332adeL71-L72. I understand there are two concepts we care about the CloudEvent and the AuditLog. We should add more comments to make that clear to the user.
|
averikitsch
reviewed
Nov 22, 2021
averikitsch
approved these changes
Nov 22, 2021
sofisl
approved these changes
Nov 22, 2021
muncus
added a commit
to GoogleCloudPlatform/golang-samples
that referenced
this pull request
Nov 24, 2021
changes to canonical sample were made in GoogleCloudPlatform/nodejs-docs-samples#2433
muncus
added a commit
to GoogleCloudPlatform/golang-samples
that referenced
this pull request
Dec 1, 2021
* feat(functionsv2): Add sample for Audit Logs Sample function prints fields, and has been tested with GCS write audit logs. * fix: remove unmatched region tag, and mod tidy. * Quick fix for audit log tests. I removed a log statement that the tests were looking for 🤦 * remove use of google-cloudevents library instead, use minimal structs to unmarshal protoPayload. * Add explicit field names to structs in the tests list * Update output to reflect changes to canonical sample changes to canonical sample were made in GoogleCloudPlatform/nodejs-docs-samples#2433 * Wrap error returned when calling DataAs() Co-authored-by: Ace Nassri <[email protected]>
noerog
pushed a commit
that referenced
this pull request
Sep 2, 2022
* chore(functions/v2): address comments on CAL samples * Address comments * Address Averi's comments
Cori1109
added a commit
to Cori1109/golang-samples
that referenced
this pull request
Jan 9, 2023
* feat(functionsv2): Add sample for Audit Logs Sample function prints fields, and has been tested with GCS write audit logs. * fix: remove unmatched region tag, and mod tidy. * Quick fix for audit log tests. I removed a log statement that the tests were looking for 🤦 * remove use of google-cloudevents library instead, use minimal structs to unmarshal protoPayload. * Add explicit field names to structs in the tests list * Update output to reflect changes to canonical sample changes to canonical sample were made in GoogleCloudPlatform/nodejs-docs-samples#2433 * Wrap error returned when calling DataAs() Co-authored-by: Ace Nassri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge for me once this LGTM. Thanks!