Skip to content

chore(functions): address comments on CAL samples #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ace-n merged 6 commits into from
Nov 5, 2021
Merged

chore(functions): address comments on CAL samples #2402

ace-n merged 6 commits into from
Nov 5, 2021

Conversation

@ace-n
Copy link
Contributor

@ace-n ace-n commented Nov 2, 2021

No description provided.

@ace-n ace-n requested a review from averikitsch November 2, 2021 21:19
@ace-n ace-n requested a review from a team as a code owner November 2, 2021 21:19
@product-auto-label product-auto-label bot added the api: cloudfunctions Issues related to the Cloud Run functions API. label Nov 2, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 2, 2021
averikitsch
averikitsch approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@averikitsch averikitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nits

@ace-n ace-n requested a review from sofisl November 2, 2021 23:27
@ace-n ace-n added the automerge Merge the pull request once unit tests and other checks pass. label Nov 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 3, 2021
@ace-n ace-n merged commit bc5afa6 into main Nov 5, 2021
@ace-n ace-n deleted the cal-akitsch branch November 5, 2021 21:24
noerog pushed a commit that referenced this pull request Sep 2, 2022
@JustinBeckwith @noerog
chore(functions): address comments on CAL samples (#2402)
e1b5980 
* chore(functions): address comments on CAL samples

* Fix lint

* Remove stray dbg statement

* Address comments

* nit

Co-authored-by: Justin Beckwith <[email protected]>
@ninadhatkar ninadhatkar mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch averikitsch approved these changes

@sofisl sofisl Awaiting requested review from sofisl

+1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: cloudfunctions Issues related to the Cloud Run functions API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ace-n @JustinBeckwith @averikitsch