Update GCF tests #2399
Merged
Update GCF tests #2399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
google-cla
bot
added
the
cla: yes
ace-n
approved these changes
Oct 29, 2021
| if (!bucketName) { | ||
| throw new Error('"FUNCTION_DELETABLE_BUCKET" env var must be set.'); | ||
| } | ||
| if (!process.env.GCF_REGION) { |
Contributor
There was a problem hiding this comment.
Nit: should this be its own variable, since it's used in multiple places?
(If so, apply this comment throughout your PR.)
Contributor
Author
There was a problem hiding this comment.
Leaving for a future update...
noerog
pushed a commit
that referenced
this pull request
Sep 2, 2022
* Update GCF tests * lint Co-authored-by: sofisl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2398
Fixes #2380