build: enable cloud build for healthcare/dicom #2316
Conversation
product-auto-label
bot
added
the
samples
google-cla
bot
added
the
cla: yes
JustinBeckwith
added
the
do not merge
| process.env.GOOGLE_APPLICATION_CREDENTIALS, | ||
| 'Must set GOOGLE_APPLICATION_CREDENTIALS environment variable!' | ||
| ); | ||
| projectId = await storage.getProjectId(); |
There was a problem hiding this comment.
Is this storage.getProjectId() just because the Storage client is being used in this file? As opposed to google.auth.getProjectId().
There was a problem hiding this comment.
Yup, it calls the same underlying method. I used storage.getProjectId() because we already had a storage client, and it just exposes the underlying auth method. This method is available on all client libraries.
|
@JustinBeckwith any reason we can't merge this? seems to have run the dicom test. We're currently blocking on this test here. |
JustinBeckwith
changed the title
JustinBeckwith
removed
the
do not merge
|
@bcoe this PR shouldn't be blocking anything - I am guessing that's a result of Cloud Build not re-running the trigger after the branch transition. I am guessing that pushing to that other branch any change will kickstart the cloud build job. That having been said, we could totally merge this now with no side effects. |
* do not merge: poke dicom test * boop * make tests more pliable * huh?
4 participants
No description provided.