Skip to content

chore: activate no-unused-vars eslint rule #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhinkel merged 1 commit into from
Oct 30, 2020
Merged

chore: activate no-unused-vars eslint rule #2037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"rules": {
"node/no-missing-require": ["off"],
"node/no-unpublished-require": ["off"],
"no-unused-vars": ["off"],
"node/no-deprecated-api": ["off"],
"no-process-exit": ["off"]
}
Expand Down
4 changes: 2 additions & 2 deletions cloud-sql/sqlserver/mssql/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ app.use(async (req, res, next) => {
});

// Serve the index page, showing vote tallies.
app.get('/', async (req, res, next) => {
app.get('/', async (req, res) => {
try {
// Get the 5 most recent votes.
const recentVotesQuery = pool
Expand Down Expand Up @@ -171,7 +171,7 @@ app.get('/', async (req, res, next) => {
});

// Handle incoming vote requests and inserting them into the database.
app.post('/', async (req, res, next) => {
app.post('/', async (req, res) => {
const {team} = req.body;
const timestamp = new Date();

Expand Down
3 changes: 1 addition & 2 deletions functions/http/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@
"devDependencies": {
"mocha": "^8.0.0",
"proxyquire": "^2.1.0",
"sinon": "^9.0.0",
"uuid": "^8.0.0"
"sinon": "^9.0.0"
},
"dependencies": {
"@google-cloud/storage": "^5.0.0",
Expand Down
1 change: 0 additions & 1 deletion functions/http/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
const proxyquire = require('proxyquire').noCallThru();
const sinon = require('sinon');
const assert = require('assert');
const uuid = require('uuid');

const getSample = () => {
const requestPromise = sinon
Expand Down
1 change: 0 additions & 1 deletion healthcare/datasets/system-test/datasets.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

'use strict';

const path = require('path');
const assert = require('assert');
const uuid = require('uuid');
const {execSync} = require('child_process');
Expand Down
4 changes: 1 addition & 3 deletions healthcare/fhir/patchFhirResource.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,7 @@ function main(
requestBody: patchOptions,
};

const resource = await healthcare.projects.locations.datasets.fhirStores.fhir.patch(
request
);
await healthcare.projects.locations.datasets.fhirStores.fhir.patch(request);
console.log(`Patched ${resourceType} resource`);
}

Expand Down
3 changes: 1 addition & 2 deletions jobs/v4/job_search_create_client_event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ function sampleCreateClientEvent(projectId, tenantId, requestId, eventId) {
};
client
.createClientEvent(request)
.then(responses => {
const response = responses[0];
.then(() => {
console.log('Created client event');
})
.catch(err => {
Expand Down