feat: add event type conversion to run pubsub event sample #1971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
grant
commented
Sep 10, 2020
grant
commented
- Adds event type to Run Pub/Sub sample for IDE autocompletion.
Signed-off-by: Grant Timmerman <[email protected]>
Signed-off-by: Grant Timmerman <[email protected]>
google-cla
bot
added
the
cla: yes
Signed-off-by: Grant Timmerman <[email protected]>
product-auto-label
bot
added
the
samples
sofisl
added
the
kokoro:force-run
sofisl
removed
the
kokoro:force-run
grayside
approved these changes
Sep 17, 2020
ace-n
approved these changes
Sep 17, 2020
|
|
||
| // [START run_events_pubsub_handler] | ||
| const express = require('express'); | ||
| const {toMessagePublishedEvent} = require('@google/events/cloud/pubsub/v1/MessagePublishedData'); |
Contributor
There was a problem hiding this comment.
Nit - I don't imagine someone can do something like this?
const {toMessagePublishedEvent} = require('@google/events/cloud/pubsub/v1').MessagePublishedData;
(I ask because this format makes reverse engineering/"exploring" the "type definition universe" a bit easier, via Node's built-in debugging tools.)
Contributor
Author
There was a problem hiding this comment.
Yup, we can do that. Going to hold off for right now though.
| const name = pubSubMessage.data | ||
| ? Buffer.from(pubSubMessage.data, 'base64').toString().trim() | ||
| // Cast to MessagePublishedEvent for IDE autocompletion | ||
| const pubSubMessage = toMessagePublishedEvent(req.body); |
Contributor
There was a problem hiding this comment.
Nit: would message be too non-descript here? (It's shorter 🙂 )
Contributor
Author
There was a problem hiding this comment.
grant
commented
Sep 24, 2020
|
|
||
| // [START run_events_pubsub_handler] | ||
| const express = require('express'); | ||
| const {toMessagePublishedEvent} = require('@google/events/cloud/pubsub/v1/MessagePublishedData'); |
Contributor
Author
There was a problem hiding this comment.
Yup, we can do that. Going to hold off for right now though.
| const name = pubSubMessage.data | ||
| ? Buffer.from(pubSubMessage.data, 'base64').toString().trim() | ||
| // Cast to MessagePublishedEvent for IDE autocompletion | ||
| const pubSubMessage = toMessagePublishedEvent(req.body); |
Contributor
Author
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.