Skip to content

GCF logging: take 2 of #1734 (metrics sample deletion) #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ace-n merged 1 commit into from
May 19, 2020
Merged

GCF logging: take 2 of #1734 (metrics sample deletion) #1811

ace-n merged 1 commit into from
May 19, 2020

Conversation

@ace-n
Copy link
Contributor

@ace-n ace-n commented May 18, 2020 •
edited
Loading

Obviates #1810

@ace-n ace-n requested a review from fhinkel May 18, 2020 23:03
@ace-n ace-n requested a review from grant as a code owner May 18, 2020 23:03
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2020
@ace-n ace-n mentioned this pull request May 18, 2020
Closed
1 task
@ace-n ace-n merged commit 3eb9d83 into master May 19, 2020
@ace-n ace-n deleted the rm-metrics branch May 19, 2020 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkel fhinkel Awaiting requested review from fhinkel

1 more reviewer

@grant grant grant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ace-n @grant @googlebot