Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

GoogleCloudPlatform / nodejs-docs-samples Public

Notifications You must be signed in to change notification settings
Fork 2k
Star 2.9k

Code
Issues 22
Pull requests 16
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

fix #1710: async pooling bug in MySQL#1712

Merged

fhinkel merged 7 commits intoGoogleCloudPlatform:masterGoogleCloudPlatform/nodejs-docs-samples:masterfrom

shubha-rajan:fix-mysql-pooling-bugshubha-rajan/nodejs-docs-samples:fix-mysql-pooling-bugCopy head branch name to clipboard

Apr 20, 2020

Conversation Commits7 (7)Checks Files changed

Merged

fix #1710: async pooling bug in MySQL#1712
fhinkel merged 7 commits intoGoogleCloudPlatform:masterfrom
shubha-rajan:fix-mysql-pooling-bug

Commits

Commits on Apr 15, 2020

made ensureSchema a callback for createPool
shubha-rajan
committed
fixed unhandled promise rejection in ensureSchema
shubha-rajan
committed
stubbed table creation query in test
shubha-rajan
committed
refactor to use async/await instead of then in ensureSchema
shubha-rajan
committed
incorporate PR feedback
shubha-rajan
committed

Commits on Apr 18, 2020

Merge branch 'master' into fix-mysql-pooling-bug
shubha-rajan
authored

Commits on Apr 20, 2020

Merge branch 'master' into fix-mysql-pooling-bug
fhinkel
authored

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.