feat: add node sample for cloud composer tutorial #1708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
leahecole
requested changes
Apr 7, 2020
Contributor
leahecole
left a comment
leahecole
left a comment
There was a problem hiding this comment.
A few meta questions/concerns:
- can we rename these files to be more descriptive? Something like composerDataflowTemplateOperatorJS? I know having dataflowtemplateoperator is super verbose, but it is descriptive.
- Your GH handle and mine should probably be added to the CODEOWNERS file
- we should add a README that links to the docs for this so that users who stumble across it on GH aren't super confused
…docs-samples into addComposerTutorialSample
sofisl
added
kokoro:force-run
kokoro-team
removed
kokoro:run
fhinkel
reviewed
Apr 9, 2020
fhinkel
reviewed
Apr 9, 2020
leahecole
requested changes
Apr 10, 2020
Contributor
leahecole
left a comment
leahecole
left a comment
There was a problem hiding this comment.
just one nit about the codeowners, then whatever Franzi has to say and we're good :)
…docs-samples into addComposerTutorialSample
sofisl
added
kokoro:force-run
kokoro-team
removed
kokoro:run
This was referenced Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.