Skip to content

cleanup: delete unused variables in functions/helloworld #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhinkel merged 2 commits into from
Nov 27, 2019
Merged

cleanup: delete unused variables in functions/helloworld #1556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6568a1b
cleanup: delete unused variables in functions/helloworld
fhinkel Nov 27, 2019
898e120
Merge branch 'master' into helloworld
fhinkel Nov 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion functions/helloworld/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"@google-cloud/pubsub": "^1.0.0",
"@google-cloud/storage": "^4.0.0",
"child-process-promise": "^2.2.1",
"delay": "^4.3.0",
"express": "^4.16.3",
"mocha": "^6.1.4",
"moment": "^2.24.0",
Expand Down
11 changes: 0 additions & 11 deletions functions/helloworld/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,8 @@ const sinon = require('sinon');
const execPromise = require('child-process-promise').exec;

const program = require('..');

const {PubSub} = require('@google-cloud/pubsub');
const pubsub = new PubSub();
const {Storage} = require('@google-cloud/storage');
const storage = new Storage();

const topicName = process.env.FUNCTIONS_TOPIC;

const localFileName = 'test.txt';
const fileName = `test-${uuid.v4()}.txt`;

const bucketName = process.env.FUNCTIONS_BUCKET;
const bucket = storage.bucket(bucketName);

const startFF = (target, signature, port) => {
const cwd = path.join(__dirname, '..');
Expand Down
1 change: 0 additions & 1 deletion functions/helloworld/test/sample.system.pubsub.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

// [START functions_pubsub_system_test]
const childProcess = require('child_process');
const delay = require('delay');
const assert = require('assert');
const uuid = require('uuid');
const {PubSub} = require('@google-cloud/pubsub');
Expand Down
1 change: 0 additions & 1 deletion functions/helloworld/test/sample.system.storage.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const uuid = require('uuid');
const assert = require('assert');
const path = require('path');
const childProcess = require('child_process');
const delay = require('delay');
const moment = require('moment');
const promiseRetry = require('promise-retry');

Expand Down