Skip to content

Update hello-world Readme #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fhinkel merged 2 commits into from
Oct 7, 2019
Merged

Update hello-world Readme #1501

fhinkel merged 2 commits into from
Oct 7, 2019
+0 −4

Conversation

@fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Oct 3, 2019

Package.json uses functions framework now.

Ref #1333

@fhinkel
Update hello-world Readme
da4ad0f 
Package.json uses functions framework now.
@fhinkel fhinkel requested review from ace-n and grant as code owners October 3, 2019 10:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2019
ace-n
ace-n approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, unless @grant thinks it's worth mentioning the framework explicitly here.

@fhinkel fhinkel merged commit d98d43e into master Oct 7, 2019
@fhinkel fhinkel deleted the fhinkel-patch-1 branch October 7, 2019 21:12
grant
grant reviewed Oct 10, 2019
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This was referenced Jun 19, 2022
Open
Open
@leejh3224 leejh3224 mentioned this pull request Jun 20, 2022
Open
This was referenced Jun 20, 2022
Open
Open
Open
@ninadhatkar ninadhatkar mentioned this pull request Jun 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@grant grant grant left review comments

@ace-n ace-n ace-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fhinkel @grant @ace-n @googlebot