refactor: prefer template strings #1492
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
|
We should make these ERRORs - otherwise CI won't flag regressions.
Also - isn't this already covered in #1489?
…On Mon, Sep 23, 2019, 8:30 AM Kurtis Van Gent ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM for /cloud-sql/
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1492?email_source=notifications&email_token=AARTZRPEVRV56IOZGWBCHNDQLDOIDA5CNFSM4IZKN4RKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFSYJMQ#pullrequestreview-291865778>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARTZRM2X5BTTS2Y5EKI77DQLDOIDANCNFSM4IZKN4RA>
.
|
gguuss
approved these changes
Sep 23, 2019
Contributor
gguuss
left a comment
gguuss
left a comment
There was a problem hiding this comment.
LGTM for iot, thank you for the free refactor :)
Contributor
Author
|
Well, this looks like a different PR added template strings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer template strings throughout this repo. (Currently shows ESLint warnings)
See #1367