Skip to content

functions/imagemagick: fix "callback must be a function" error #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhinkel merged 1 commit into from
Aug 13, 2019
Merged

functions/imagemagick: fix "callback must be a function" error #1444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion functions/imagemagick/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ const blurImage = async (file, blurredBucketName) => {
}

// Delete the temporary file.
return promisify(fs.unlink(tempLocalPath));
const unlink = promisify(fs.unlink);
return unlink(tempLocalPath);
Copy link
Contributor

@ace-n ace-n Aug 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume return promisify(fs.unlink)(tempLocalPath) is either too complex or doesn't work here?

Copy link
Collaborator Author

@grayside grayside Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test that, but it seems likely to work.
My reasoning is that this is more explicit, happy to change if you prefer.

Copy link
Contributor

@fhinkel fhinkel Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like explicit samples 👍

};
// [END functions_imagemagick_blur]