Skip to content

functions/imagemagick: system tests + Node 8 upgrade #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fhinkel merged 29 commits into from
Jul 25, 2019
Merged

functions/imagemagick: system tests + Node 8 upgrade #1387

fhinkel merged 29 commits into from
Jul 25, 2019

Conversation

@ace-n
Copy link
Contributor

@ace-n ace-n commented Jun 26, 2019

No description provided.

@ace-n ace-n requested a review from fhinkel June 26, 2019 20:58
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2019
@ace-n ace-n force-pushed the gcf-imagick-node8 branch from cd35f48 to 0d0ab0b Compare June 28, 2019 08:14
@ace-n ace-n added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 8, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Jul 8, 2019

@ace-n The imagemagick tests are failing. Ping me when it's ready for another review

@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 8, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 15, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 23, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Jul 23, 2019

Linter is complaining and a few other required tests don't pass. Can you have another look?

@ace-n ace-n added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 23, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 23, 2019
@ace-n ace-n added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 23, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 23, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Jul 23, 2019

The imagemagick tests are failing again :(

@fhinkel fhinkel merged commit deae667 into master Jul 25, 2019
@fhinkel fhinkel deleted the gcf-imagick-node8 branch July 25, 2019 02:38
This was referenced Jan 17, 2022
Open
Open
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Open
Open
Open
Open
Open
@dlminvestments dlminvestments mentioned this pull request Jun 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grayside grayside grayside left review comments

@fhinkel fhinkel fhinkel approved these changes

@SurferJeffAtGoogle SurferJeffAtGoogle Awaiting requested review from SurferJeffAtGoogle

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ace-n @fhinkel @grant @grayside @googlebot @kokoro-team