fix: Add console error messages for better logging #1364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
leahecole
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Contributor
Author
|
Kokoro seems to be stuck so attempting a re-run |
leahecole
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
ace-n
reviewed
Jun 13, 2019
| ); | ||
| const tokenResponse = await res.json(); | ||
| if (tokenResponse.error) { | ||
| console.error(JSON.stringify(tokenResponse.error)); |
Contributor
There was a problem hiding this comment.
Is it worth adding something more explanatory to these, and printing out specific error details?
e.g.
console.error('Error in authorizeIap:', tokenResponse.error.message);
Contributor
Author
There was a problem hiding this comment.
Definitely can do that
…amples into error-logging-gcf
…dejs-docs-samples into error-logging-gcf
ace-n
approved these changes
Jun 13, 2019
Contributor
ace-n
left a comment
ace-n
left a comment
There was a problem hiding this comment.
LGTM once (tiny) nit is fixed. 🙂
| ); | ||
| const tokenResponse = await res.json(); | ||
| if (tokenResponse.error) { | ||
| console.error('Error in token reponse:' + tokenResponse.error.message); |
Contributor
There was a problem hiding this comment.
Tiny nit: use a comma instead of +? (console.error can take two arguments, and this is more idiomatic vs. our other samples.)
ace-n
approved these changes
Jun 14, 2019
Contributor
ace-n
left a comment
ace-n
left a comment
There was a problem hiding this comment.
LGTM, assuming error.message is the correct object format.
(The tests should cover this, but it wouldn't hurt to verify this in GCF to be on the safe side.)
Contributor
Author
|
Yup - I verified this in GCF @ace-n |
This was referenced Jan 17, 2022
Merged
Merged
Merged
Merged
This was referenced Jan 17, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1362