Skip to content

fix: Fixes GAE headless chrome region tags. See #834 #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grant merged 3 commits into from
Jun 11, 2019
Merged

fix: Fixes GAE headless chrome region tags. See #834 #1356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb2741f
fix: Fixes GAE headless chrome region tags. See #834
grant Jun 11, 2019
87a2970
Merge branch 'master' into grant_headless_chrome_region
grant Jun 11, 2019
0282b76
Update app.js
grant Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions appengine/headless-chrome/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ limitations under the License.
*/
'use strict';

// [START full_sample]
// [START gae_std_headless_chrome_full_sample]
const express = require('express');
const puppeteer = require('puppeteer');
const app = express();
Expand All @@ -32,11 +32,11 @@ app.use(async (req, res) => {
}

if (!browser) {
// [START browser]
// [START gae_std_headless_chrome_full_sample_browser]
browser = await puppeteer.launch({
args: ['--no-sandbox'],
});
// [END browser]
// [END gae_std_headless_chrome_full_sample_browser]
}

const page = await browser.newPage();
Expand All @@ -54,6 +54,6 @@ const server = app.listen(process.env.PORT || 8080, err => {
const {port} = server.address();
console.info(`App listening on port ${port}`);
});
// [END full_sample]
// [END gae_std_headless_chrome_full_sample]

module.exports = app;
4 changes: 2 additions & 2 deletions appengine/headless-chrome/app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# See the License for the specific language governing permissions and
# limitations under the License

# [START app_yaml]
# [START gae_std_headless_chrome_app_yaml]
runtime: nodejs10
instance_class: F4_1G
# [END app_yaml]
# [END gae_std_headless_chrome_app_yaml]