Skip to content

Conversation

@ace-n
Copy link
Contributor

@ace-n ace-n commented May 21, 2019

Do not merge until samples have been updated to conform to these standards.

@ace-n ace-n requested review from JustinBeckwith and fhinkel May 21, 2019 18:27
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2019
@fhinkel
Copy link
Contributor

fhinkel commented May 21, 2019

Looks good to me. But we need to update a lot of samples first. I'd prefer if we'd use the same linting rules as the client libraries.

Also, how does this work with the functions samples that are currently tested on Node 6?

@ace-n
Copy link
Contributor Author

ace-n commented May 21, 2019

  • Updating samples - yep, I figured as much. 🙂I wanted to make sure we agreed on the rules before I updated any samples though.
  • Copy linting rules from the client libraries - those are less restrictive than these (e.g. prefer-await-to-then isn't there, but it's part of our Node 8 upgrade process).
  • functions samples - I'm following up more on this internally. I might add an exception to these (either via in-file comments, or a lower-level eslintrc.yml) until we agree on a path forward.

Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 29, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 29, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 29, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 29, 2019
@ace-n ace-n merged commit daf554a into master May 29, 2019
@ace-n ace-n deleted the eslint-node8 branch May 29, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants