refactor(functions/tips): ava to mocha #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add script to run tests
googlebot
added
the
cla: yes
Contributor
Author
|
@fhinkel there was no script to run the test. I added it, let me know if it is OK. |
kokoro-team
removed
the
kokoro:run
AVaksman
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
fhinkel
reviewed
Apr 4, 2019
functions/tips/test/index.test.js
Outdated
| const tools = require(`@google-cloud/nodejs-repo-tools`); | ||
|
|
||
| const sample = require(`../`); | ||
| process.env.FUNCTIONS_TOPIC = |
Contributor
There was a problem hiding this comment.
Should this be hard coded here?
Contributor
Author
There was a problem hiding this comment.
Just saw it myself, removed it
kokoro-team
removed
kokoro:run
fhinkel
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1080