-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(deps): update dependency @google-cloud/translate to v3 #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e73ff12 to
8eef74a
Compare
f131135 to
59cf807
Compare
|
@ace-n, can you take on this functions sample? |
|
I didn't write these samples. @crwilcox is this something you (or the client libraries team more broadly) can address? (If not, ping me and I'll take another look.) |
896a169 to
584ca22
Compare
|
Who wrote the functions samples? @ace-n |
|
#777 - looks like this was an ML team's sample. @beccasaurus do you know if someone officially owns these (specifically GCF samples that use X API), or is that something our respective teams (@sgreenberg <--> @andrewsg) should chat about? |
|
I'm unfamiliar with the OCR sample.
It should certainly be kept up-to-date, dependency-wise etc :) You have my +1 on the dependency upgrade. |
|
@ricalo is the failing test something you'd be willing to investigate? (Based on @beccasaurus' comment, it seems like you intended to maintain it - apologies for assuming otherwise. If not - then we should figure out who does own it going forward. 🙂) |
|
Yes, I can take issues related to the Is only the I can look in more detail at this next week, but let me know what you think in the meantime. |
|
Thanks @ricalo for looking into this. |
584ca22 to
04ddcb6
Compare
|
Hi @fhinkel. Any idea why the checks seem to be stuck in |
04ddcb6 to
eca1849
Compare
|
@ricalo hard to tell, sometimes it's just a reporting problem. If you have access to the internal tool, you can restart individual tests. |
|
All tests passed. Should I merge? |
eca1849 to
c3f4c12
Compare
|
LGTM, but it's not my call. |
11e2704 to
6b15044
Compare
6b15044 to
8125bd0
Compare
|
@gguuss The iot tests time out here. Could you have a look? Seems unrelated. |
This PR contains the following updates:
^2.1.2->^3.0.0Release Notes
googleapis/nodejs-translate
v3.0.1Compare Source
04-09-2019 12:19 PDT
Fixes
Dependencies
Documentation / Samples
Internal / Testing Changes
v3.0.0Compare Source
BREAKING CHANGE:
This release introduces the
grpcdependency.In some environments, this will trigger a native compilation.
Implementation Changes
New Features
Dependencies
Documentation
Internal / Testing Changes
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "
rebase!".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.